Add DOCKERFILE

This adds a docker setup as in #1 to run the examples and some hints in the readme on how to use it.

It uses the "isolated" way to run GUI in docker containers described in http://wiki.ros.org/docker/Tutorials/GUI#The_isolated_way . I think it should be sufficiently secure. The only downside is that you have to change the DOCKERFILE if your user is not the primary user on your system.

added 1 commit

• 4ae56a96 - Copy clone hint for docker setup

Compare with previous version

assigned to @johannes.mey

Looks good. Do you know why the pipeline fails? Probably, because you only cloned the workspace repo, right? So the submodules are not found. I guess it is fine now, since you did not change anything related to the pipeline, but I have also added you to the project, so you can create feature branches instead of forking from now on.

It would be nicer to make uid and gid ARGs and provide a startup script like https://github.com/pierrekilly/docker-ros-box

Also, are there some other optimizations we could take from this repo?

added 2 commits

• 21b9ab91 - ref #1: Move package retrieval before source copy so that it can be cached
• 9796f0ca - ref #1: Use container build args for UID and GID, move build to run script, update README

Compare with previous version

added 1 commit

• b616f8f9 - ref #1: Add dri device mount for hardware acceleration

Compare with previous version

It would be nicer to make uid and gid ARGs and provide a startup script like https://github.com/pierrekilly/docker-ros-box

Good point, I was not aware of the build-arg functionality.

Also, are there some other optimizations we could take from this repo?

I added the lines mentioned in http://wiki.ros.org/docker/Tutorials/Hardware%20Acceleration for hardware acceleration with AMD / Intel FOSS drivers. The visualization now runs much more smoothly on my system compared to the inital merge request version, so it appears to be working.

Looks good to me and works with my setup.

@timklge do you think we should have a MacOS user test it?

@timklge do you think we should have a MacOS user test it?

I am not familiar with Mac OS and the docker adaptation, but I think Docker on Mac works in the same way as the Windows Docker; it starts a VM running a minimal linux. So you would need to use some kind of X11 forwarding. I think merging the current version and considering it linux-only would be sufficient for the time being.

sure. The problem is that many people use macbooks. but I guess we have to postpone this. The same holds for people using other container engines than docker (such as those with Fedora Linux).

merged

mentioned in commit 7391d826