Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
P
panda_grasping
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Container registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
CeTI
ROS
ROS Packages
panda_grasping
Commits
9326ad1c
Commit
9326ad1c
authored
4 years ago
by
Sebastian Ebert
Browse files
Options
Downloads
Patches
Plain Diff
fixes from merge request
parent
6e66b3b9
No related branches found
No related tags found
No related merge requests found
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
src/grasping/grasp_service.cpp
+2
-2
2 additions, 2 deletions
src/grasping/grasp_service.cpp
src/grasping/grasp_util.cpp
+2
-14
2 additions, 14 deletions
src/grasping/grasp_util.cpp
srv/PickObject.srv
+1
-0
1 addition, 0 deletions
srv/PickObject.srv
srv/PlaceObject.srv
+1
-0
1 addition, 0 deletions
srv/PlaceObject.srv
with
6 additions
and
16 deletions
src/grasping/grasp_service.cpp
+
2
−
2
View file @
9326ad1c
...
...
@@ -74,7 +74,7 @@ bool pickObject(panda_grasping::PickObject::Request &req,
ROS_INFO
(
"Picking up ..."
);
// 0.08 = 8cm = maximum gripper opening
if
(
!
grasp_util
.
pickFromAbove
(
group
,
pick_pose
,
req
.
dimensions
,
0.08
,
"pick_support"
,
"pick_object"
))
{
if
(
!
grasp_util
.
pickFromAbove
(
group
,
pick_pose
,
req
.
dimensions
,
0.08
,
"pick_support"
,
"pick_object"
,
req
.
plan_only
))
{
res
.
success
=
false
;
return
false
;
}
...
...
@@ -121,7 +121,7 @@ placeObject(panda_grasping::PlaceObject::Request &req, panda_grasping::PlaceObje
}
ROS_INFO
(
"Placing object."
);
if
(
!
grasp_util
.
placeFromAbove
(
group
,
req
.
pose
,
0.08
,
"place_support"
,
"pick_object"
))
{
if
(
!
grasp_util
.
placeFromAbove
(
group
,
req
.
pose
,
0.08
,
"place_support"
,
"pick_object"
,
req
.
plan_only
))
{
res
.
success
=
false
;
return
false
;
}
...
...
This diff is collapsed.
Click to expand it.
src/grasping/grasp_util.cpp
+
2
−
14
View file @
9326ad1c
...
...
@@ -113,13 +113,7 @@ GraspUtil::pickFromAbove(moveit::planning_interface::MoveGroupInterface &move_gr
move_group
.
setSupportSurfaceName
(
supporting_surface_id
);
moveit_msgs
::
MoveItErrorCodes
miec
;
if
(
plan_only
){
miec
=
move_group
.
pick
(
object_to_pick_id
,
grasps
,
true
);
}
else
{
miec
=
move_group
.
pick
(
object_to_pick_id
,
grasps
);
}
moveit_msgs
::
MoveItErrorCodes
miec
=
move_group
.
pick
(
object_to_pick_id
,
grasps
,
plan_only
);
if
(
miec
.
val
==
miec
.
SUCCESS
)
{
return
true
;
...
...
@@ -155,13 +149,7 @@ GraspUtil::placeFromAbove(moveit::planning_interface::MoveGroupInterface &move_g
setupOpenGripper
(
place_location
[
0
].
post_place_posture
,
open_amount
);
move_group
.
setSupportSurfaceName
(
supporting_surface_id
);
moveit_msgs
::
MoveItErrorCodes
miec
;
if
(
plan_only
){
miec
=
move_group
.
place
(
object_to_place_id
,
place_location
,
true
);
}
else
{
miec
=
move_group
.
place
(
object_to_place_id
,
place_location
);
}
moveit_msgs
::
MoveItErrorCodes
miec
=
move_group
.
place
(
object_to_place_id
,
place_location
,
plan_only
);
if
(
miec
.
val
==
miec
.
SUCCESS
)
{
return
true
;
...
...
This diff is collapsed.
Click to expand it.
srv/PickObject.srv
+
1
−
0
View file @
9326ad1c
geometry_msgs/Pose pose
geometry_msgs/Vector3 dimensions
bool plan_only
---
bool success
\ No newline at end of file
This diff is collapsed.
Click to expand it.
srv/PlaceObject.srv
+
1
−
0
View file @
9326ad1c
geometry_msgs/Pose pose
geometry_msgs/Vector3 dimensions
bool plan_only
---
bool success
\ No newline at end of file
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment