Skip to content
Snippets Groups Projects
Commit 6298a6e7 authored by René Schöne's avatar René Schöne
Browse files

update based on reviewer comments

parent be9f7e93
No related branches found
No related tags found
No related merge requests found
...@@ -136,12 +136,12 @@ There are some possible sources of errors. ...@@ -136,12 +136,12 @@ There are some possible sources of errors.
(1) The RAG application fails to write the SVG. (1) The RAG application fails to write the SVG.
This would be visible as a Java exception in the log output of `docker-compose up rag_place_b`. This would be visible as a Java exception in the log output of `docker-compose up rag_place_b`.
The directory `/ros3rag/ros3rag.placeB/images` has to exist in the container and must be writeable. The directory `/ros3rag/images` has to exist in the container and must be writeable.
Fixing this is not easy, a possibility is to create a new Dockerfile based on `models2022_rag_place` and add `RUN mkdir /ros3rag/ros3rag.placeB/images` to create this directory manually there. Fixing this is not easy, a possibility is to attach to the running container of `rag_place_b` and make sure, that the directory `/ros3rag/images` is writeable.
(2) The SVG was written but is not readable for the web UI. (2) The SVG was written but is not readable for the web UI.
Everytime an SVG is received, its original and rewritten path is logged for the container of `docker-compose up web`. Everytime an SVG is received, its original and rewritten path is logged for the container of `docker-compose up web`.
As an alternative, you can manually view these images, since they reside on your host machine in the directory `shared_directory_images`. As an alternative, you can manually view these images, since they reside on your host machine in the volume `shared_images`.
### Error: build path [...] either does not exist, is not accessible, or is not a valid URL ### Error: build path [...] either does not exist, is not accessible, or is not a valid URL
......
mqttHost: "localhost" mqttHost: "mosquitto"
filenameRegions: "src/main/resources/regions-b-placeworld.json" filenameRegions: "src/main/resources/regions-b-placeworld.json"
forB: forB:
topicsSceneUpdate: topicsSceneUpdate:
......
Subproject commit d89b06603434dd1d6e47b53346ae0e18f3954033 Subproject commit 8c64aa2ba0a711479f3a59f65b25c27b287c81ac
...@@ -4,7 +4,7 @@ services: ...@@ -4,7 +4,7 @@ services:
image: models2022_ros_place:latest image: models2022_ros_place:latest
build: build:
context: robotic-controller context: robotic-controller
dockerfile: Dockerfile-vnc-foo dockerfile: Dockerfile-vnc
volumes: volumes:
- "./ros_place_b1_logs/:/home/root/.ros/log" - "./ros_place_b1_logs/:/home/root/.ros/log"
ports: ports:
...@@ -36,14 +36,16 @@ services: ...@@ -36,14 +36,16 @@ services:
- "TARGET=ros3rag.placeB" - "TARGET=ros3rag.placeB"
- "CONFIG_FILE=/ros3rag/config-b-docker.yaml" - "CONFIG_FILE=/ros3rag/config-b-docker.yaml"
volumes: volumes:
- "./shared_directory_images:/ros3rag/images" - "shared_images:/ros3rag/images:rw"
- "./config/config-b-docker.yaml:/ros3rag/config-b-docker.yaml" - "./config/config-b-docker.yaml:/ros3rag/config-b-docker.yaml"
coordinator: coordinator:
image: models2022_coordinator:latest image: models2022_coordinator:latest
build: coordinator build: coordinator
environment: command: # will be parameters to entrypoint
- "CONFIG_FILE=/coordinator/ros3rag.coordinator" - "--dry-run"
- "--mqtt-host=mosquitto"
- "/ros3rag.coordinator"
volumes: volumes:
- "./config/ros3rag.coordinator:/ros3rag.coordinator" - "./config/ros3rag.coordinator:/ros3rag.coordinator"
...@@ -51,7 +53,7 @@ services: ...@@ -51,7 +53,7 @@ services:
image: models2022_web:latest image: models2022_web:latest
build: web-ros3rag build: web-ros3rag
volumes: volumes:
- "./shared_directory_images:/shared_directory_images" - "shared_images:/shared_directory_images:ro"
- "./config/web-config.yaml:/app/config.yaml" - "./config/web-config.yaml:/app/config.yaml"
ports: ports:
- "8050:8050" - "8050:8050"
...@@ -64,3 +66,5 @@ services: ...@@ -64,3 +66,5 @@ services:
restart: unless-stopped restart: unless-stopped
volumes: volumes:
- ./config/mosquitto.conf:/mosquitto/config/mosquitto.conf - ./config/mosquitto.conf:/mosquitto/config/mosquitto.conf
volumes:
shared_images:
...@@ -14,14 +14,16 @@ Documentation: <https://jastadd.pages.st.inf.tu-dresden.de/ragconnect-minimal> ...@@ -14,14 +14,16 @@ Documentation: <https://jastadd.pages.st.inf.tu-dresden.de/ragconnect-minimal>
Repositories Repositories
- RAG part: <https://git-st.inf.tu-dresden.de/jastadd/ros3rag> - RAG part: <https://git-st.inf.tu-dresden.de/jastadd/ros3rag>
- ROS parts: <https://git-st.inf.tu-dresden.de/ceti/ros/ccf> - ROS part: <https://git-st.inf.tu-dresden.de/ceti/ros/ccf>
- Web UI: <https://git-st.inf.tu-dresden.de/jastadd/web-ros3rag>
- Coordinator: <https://git-st.inf.tu-dresden.de/jastadd/coordinator>
- Complete workspace: <https://git-st.inf.tu-dresden.de/ceti/ros/models2022> - Complete workspace: <https://git-st.inf.tu-dresden.de/ceti/ros/models2022>
# Other Used Tools # Other Used Tools
Visualization of Grammar: <https://jastadd.pages.st.inf.tu-dresden.de/grammar2uml/> Visualization of Grammars: <https://jastadd.pages.st.inf.tu-dresden.de/grammar2uml/>
Visualization of AST: <https://jastadd.pages.st.inf.tu-dresden.de/relast2uml/> Visualization of ASTs: <https://jastadd.pages.st.inf.tu-dresden.de/relast2uml/>
RelAST: <https://jastadd.pages.st.inf.tu-dresden.de/relational-rags/> RelAST: <https://jastadd.pages.st.inf.tu-dresden.de/relational-rags/>
......
Subproject commit aea32b90b5ce5c0511d5244e4e6d8c0f18c4a406 Subproject commit 372ec585bef99589280c5f571ba39100b7b3b2ec
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment