Clean-up, document and rename some attributes.

• Structured analysis file to better find attributes, and documented some of the attributes
• Added one error test case for a role being already declared (see Errors and ErrorsLeft)
• Removed unused attributes
• Renamed attributes to better match their purpose
• Effectively removed LeftDirection from analysis, as it is now parsed as an inversed RightDirection (as we do not have round-trip parse-print-parse tests, this is not a problem)

src/main/jastadd/Analysis.jrag

@@ -76,26 +76,30 @@ aspect ComponentAnalysis {
     return null;
   }
 
-  /* Should this better return the component, where it is defined previously defined? */
   //--- isInvalidRedefinition ---
   /**
    * Check, if a component with the same name is already declared in some supertype
    */
-  syn boolean Component.isInvalidRedefinition() = false;
-  eq TokenComponent.isInvalidRedefinition() = hasInvalidRedefinitionOn(enclosingTypeDecl());
-  eq RelationComponent.isInvalidRedefinition() = hasInvalidRedefinitionOn(getTypeUse().decl());
+  syn boolean Component.isInvalidRedefinition() = invalidRedefinition() != null;
 
-  syn boolean Component.hasInvalidRedefinitionOn(TypeDecl td) {
-    if (td == null) return false;
+  /**
+   * Check, if a component with the same name is already declared in some supertype, and return it, if any
+   */
+  syn Component Component.invalidRedefinition() = null;
+  eq TokenComponent.invalidRedefinition() = invalidRedefinitionOn(enclosingTypeDecl());
+  eq RelationComponent.invalidRedefinition() = invalidRedefinitionOn(getTypeUse().decl());
+
+  syn Component Component.invalidRedefinitionOn(TypeDecl td) {
+    if (td == null) return null;
 
     while (td.hasSuper() && td.getSuper().decl() != null) {
       td = td.getSuper().decl();
       // find a matching component on the RHS of the (current) super type
       Component c = findComponent(td, getID());
 
-      if (c != null && !this.isEqual(c)) return true;
+      if (c != null && !this.isEqual(c)) return c;
     }
-    return false;
+    return null;
   }
 
   //--- isEqual ---