removed grayed out options from ricght click menu; researched cause and ways...

removed grayed out options from ricght click menu; researched cause and ways to fix out of focus view for loaded diagrams

TaskAndTimeTimJahn.txt

@@ -57,6 +57,7 @@ hours:
 19.01.25  4h
 26.01.25  8h
 27.01.25  2h
+06.03.25  8h
 //------------------------------------------------------------------------------------------------------
 
 see https://github.com/eclipse-theia/theia/blob/master/doc/Developing.md#prerequisite_native_keymap
@@ -185,7 +186,27 @@ further things:
 	- https://github.com/eclipse-sprotty/sprotty/issues/94
 
 
-next meeting: 3.2.25
+#9 diagram not centered if opened
+	- https://github.com/eclipse-glsp/glsp/discussions/454
+	my assumption is, that fixing the alignment of the enclosing page shoul fix this problem
+
+	problem: editor opens view at fixed size and position - if the diagram is shifted from initial 
+	view during modifications (i.e. open a diagram thats still in view, move it outside of view and save, 
+	then relaod the page) it will stay out of view until fixed manually
+
+	potential solution (chatgpt): viewer.fitToViewport(); // no idea where this should go (client), but the function 
+														  //  should align the diagram to the view
+
+		alternative:  			  viewer.centerOnElement(); // doing so after every modification with the global page will ensure the diagram stys centralised but may interfere with navigation
+
+#10 disconnect if reopened
+	cannot reproduce this; if the browser is reopened, open editor tabs seem to not really load 
+	the diagram or the menu - can be fixed by closing editor (not browser) tabs and then reopening 
+	them - potentially reloading the editor may also help
+
+#11 remove tina, gray options in right-click
+
+next meeting: 10.3.25
 
 --------------------------------------------------------------------------------------------
 

glsp-client/tasklist-theia/src/browser/diagram/copy-id-context-menu.ts

@@ -31,7 +31,8 @@ export class CopyIdCommandContribution implements CommandContribution {
             { id: CopyIdCommand.COPY_ID, label: 'Copy Id' },
             new GLSPCommandHandler(this.shell, {
                 actions: context => [CopyToClipboardAction.create(context.selectedElements[0].id)],
-                isEnabled: context => !context.isReadonly && context.selectedElements.length === 1
+                isEnabled: context => !context.isReadonly && context.selectedElements.length === 1,
+                isVisible: context => !context.isReadonly && context.selectedElements.length === 1
             })
         );
     }

glsp-client/tasklist-theia/src/browser/diagram/edit-tokens-context-menu.ts

@@ -38,7 +38,8 @@ export class EditTokensMenuCommandContribution implements CommandContribution {
                         contextElementsId: [context.selectedElements[0].id]
                     })
                 ],
-                isEnabled: context => !context.isReadonly && context.selectedElements.filter(isPlace).length === 1
+                isEnabled: context => !context.isReadonly && context.selectedElements.filter(isPlace).length === 1,
+                isVisible: context => !context.isReadonly && context.selectedElements.filter(isPlace).length === 1
             })
         );
     }

glsp-client/tasklist-theia/src/browser/diagram/fire-transtition-context-menu.ts

@@ -31,7 +31,8 @@ export class FireTransitionCommandContribution implements CommandContribution {
             { id: FireTransitionCommand.FIRE_TRANSITION, label: 'Fire Transition' },
             new GLSPCommandHandler(this.shell, {
                 actions: context => [FireTransitionOperation.create(context.selectedElements.filter(isTransition)[0].id)],
-                isEnabled: context => !context.isReadonly && context.selectedElements.filter(isTransition).length === 1
+                isEnabled: context => !context.isReadonly && context.selectedElements.filter(isTransition).length === 1,
+                isVisible: context => !context.isReadonly && context.selectedElements.filter(isTransition).length === 1
             })
         );
     }

glsp-client/tasklist-theia/src/browser/diagram/signal-clause-context-menu.ts

@@ -38,7 +38,8 @@ export class SignalClauseMenuCommandContribution implements CommandContribution
                         contextElementsId: [context.selectedElements[0].id]
                     })
                 ],
-                isEnabled: context => !context.isReadonly && context.selectedElements.filter(isTransition).length === 1
+                isEnabled: context => !context.isReadonly && context.selectedElements.filter(isTransition).length === 1,
+                isVisible: context => !context.isReadonly && context.selectedElements.filter(isTransition).length === 1
             })
         );
     }

glsp-client/workspace/test1.pnml

@@ -4,7 +4,7 @@
     <page id="4d884d55-8758-4920-a868-f5f8a987888d">
       <name text="NewPage0"/>
       <nodegraphics>
-        <position x="336" y="4"/>
+        <position x="1268" y="777"/>
         <dimension x="741" y="583"/>
       </nodegraphics>
       <arc id="c8912776-f1f9-420d-b2ee-a97af8b3290e" source="9dc009ee-13e0-48fa-ae9e-c4fb2259288d" target="d5fd7182-98e6-4af2-ad0b-72bb8f528c9a">

glsp-server/.settings/org.eclipse.jdt.core.prefs

@@ -21,13 +21,13 @@ org.eclipse.jdt.core.codeComplete.staticFinalFieldPrefixes=
 org.eclipse.jdt.core.codeComplete.staticFinalFieldSuffixes=
 org.eclipse.jdt.core.compiler.annotation.inheritNullAnnotations=disabled
 org.eclipse.jdt.core.compiler.annotation.missingNonNullByDefaultAnnotation=ignore
-org.eclipse.jdt.core.compiler.annotation.nonnull=javax.annotation.Nonnull
+org.eclipse.jdt.core.compiler.annotation.nonnull=org.eclipse.jdt.annotation.NonNull
 org.eclipse.jdt.core.compiler.annotation.nonnull.secondary=
-org.eclipse.jdt.core.compiler.annotation.nonnullbydefault=javax.annotation.ParametersAreNonnullByDefault
+org.eclipse.jdt.core.compiler.annotation.nonnullbydefault=org.eclipse.jdt.annotation.NonNullByDefault
 org.eclipse.jdt.core.compiler.annotation.nonnullbydefault.secondary=
-org.eclipse.jdt.core.compiler.annotation.nullable=javax.annotation.Nullable
+org.eclipse.jdt.core.compiler.annotation.nullable=org.eclipse.jdt.annotation.Nullable
 org.eclipse.jdt.core.compiler.annotation.nullable.secondary=
-org.eclipse.jdt.core.compiler.annotation.nullanalysis=enabled
+org.eclipse.jdt.core.compiler.annotation.nullanalysis=disabled
 org.eclipse.jdt.core.compiler.codegen.inlineJsrBytecode=enabled
 org.eclipse.jdt.core.compiler.codegen.methodParameters=do not generate
 org.eclipse.jdt.core.compiler.codegen.targetPlatform=17
@@ -91,15 +91,15 @@ org.eclipse.jdt.core.compiler.problem.noImplicitStringConversion=warning
 org.eclipse.jdt.core.compiler.problem.nonExternalizedStringLiteral=ignore
 org.eclipse.jdt.core.compiler.problem.nonnullParameterAnnotationDropped=warning
 org.eclipse.jdt.core.compiler.problem.nonnullTypeVariableFromLegacyInvocation=warning
-org.eclipse.jdt.core.compiler.problem.nullAnnotationInferenceConflict=warning
+org.eclipse.jdt.core.compiler.problem.nullAnnotationInferenceConflict=error
 org.eclipse.jdt.core.compiler.problem.nullReference=warning
-org.eclipse.jdt.core.compiler.problem.nullSpecViolation=warning
-org.eclipse.jdt.core.compiler.problem.nullUncheckedConversion=ignore
+org.eclipse.jdt.core.compiler.problem.nullSpecViolation=error
+org.eclipse.jdt.core.compiler.problem.nullUncheckedConversion=warning
 org.eclipse.jdt.core.compiler.problem.overridingPackageDefaultMethod=warning
 org.eclipse.jdt.core.compiler.problem.parameterAssignment=ignore
 org.eclipse.jdt.core.compiler.problem.pessimisticNullAnalysisForFreeTypeVariables=warning
 org.eclipse.jdt.core.compiler.problem.possibleAccidentalBooleanAssignment=warning
-org.eclipse.jdt.core.compiler.problem.potentialNullReference=warning
+org.eclipse.jdt.core.compiler.problem.potentialNullReference=ignore
 org.eclipse.jdt.core.compiler.problem.potentiallyUnclosedCloseable=ignore
 org.eclipse.jdt.core.compiler.problem.rawTypeReference=warning
 org.eclipse.jdt.core.compiler.problem.redundantNullAnnotation=warning
@@ -113,7 +113,7 @@ org.eclipse.jdt.core.compiler.problem.specialParameterHidingField=disabled
 org.eclipse.jdt.core.compiler.problem.staticAccessReceiver=warning
 org.eclipse.jdt.core.compiler.problem.suppressOptionalErrors=disabled
 org.eclipse.jdt.core.compiler.problem.suppressWarnings=enabled
-org.eclipse.jdt.core.compiler.problem.syntacticNullAnalysisForFields=enabled
+org.eclipse.jdt.core.compiler.problem.syntacticNullAnalysisForFields=disabled
 org.eclipse.jdt.core.compiler.problem.syntheticAccessEmulation=ignore
 org.eclipse.jdt.core.compiler.problem.terminalDeprecation=warning
 org.eclipse.jdt.core.compiler.problem.typeParameterHiding=warning