From c40c9d863cb1c696be910ca262b3dcb22428e683 Mon Sep 17 00:00:00 2001
From: Johannes Mey <johannes.mey@tu-dresden.de>
Date: Tue, 18 Feb 2020 19:16:35 +0100
Subject: [PATCH] apply performance bug hint from intellij
---
src/main/jastadd/DumpTree.jrag | 5 +++--
src/main/jastadd/backend/PrettyPrinting.jadd | 6 +++---
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/src/main/jastadd/DumpTree.jrag b/src/main/jastadd/DumpTree.jrag
index d1203ae..2d2f340 100644
--- a/src/main/jastadd/DumpTree.jrag
+++ b/src/main/jastadd/DumpTree.jrag
@@ -33,7 +33,7 @@ aspect DumpTree {
public String ASTNode.extraDumpInfo() { return ""; }
public String ASTNode.getTokens() {
- java.util.TreeSet<java.lang.reflect.Method> methods = new java.util.TreeSet<>(Comparator.comparing(Method::getName));
+ java.util.TreeSet<java.lang.reflect.Method> methods = new java.util.TreeSet<>(Comparator.comparing(java.lang.reflect.Method::getName));
methods.addAll(java.util.Arrays.asList(getClass().getMethods()));
@@ -43,7 +43,8 @@ aspect DumpTree {
if (token != null) {
try {
result.append(String.format(" %s=\"%s\"", token.name(), method.invoke(this)));
- } catch (IllegalAccessException | java.lang.reflect.InvocationTargetException ignored) {
+ } catch (IllegalAccessException ignored) {
+ } catch (java.lang.reflect.InvocationTargetException ignored) {
}
}
}
diff --git a/src/main/jastadd/backend/PrettyPrinting.jadd b/src/main/jastadd/backend/PrettyPrinting.jadd
index 49d33b9..63c5344 100644
--- a/src/main/jastadd/backend/PrettyPrinting.jadd
+++ b/src/main/jastadd/backend/PrettyPrinting.jadd
@@ -33,10 +33,10 @@ aspect PrettyPrinting {
aspect Utils {
public String ASTNode.ind(int n) {
- String s = "";
+ StringBuilder s = new StringBuilder();
for (int i = 0; i < n; i++) {
- s += " ";
+ s.append(" ");
}
- return s;
+ return s.toString();
}
}
--
GitLab