diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 3d80f0e766a0b64cf1f7691795974cc9e1ccc1d9..56c0e1b7d49ac9c19ac72b6e1bbc0d7be7b1191c 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -34,9 +34,6 @@ test: services: - name: "eclipse-mosquitto:1.6" alias: "mqtt" - - name: "eclipse-mosquitto:1.6" - alias: "mqtt_different_port" - command: ["mosquitto", "-p", "55883"] needs: - build script: diff --git a/ragconnect.base/src/main/java/org/jastadd/ragconnect/compiler/Compiler.java b/ragconnect.base/src/main/java/org/jastadd/ragconnect/compiler/Compiler.java index 449c1d85145fffb939ae02c5e24cd753bc670590..5f7e914fa11630a4c5013b0cc6b2896fc5934dc1 100644 --- a/ragconnect.base/src/main/java/org/jastadd/ragconnect/compiler/Compiler.java +++ b/ragconnect.base/src/main/java/org/jastadd/ragconnect/compiler/Compiler.java @@ -70,10 +70,11 @@ public class Compiler extends AbstractCompiler { RagConnect ragConnect = parseProgram(getConfiguration().getFiles()); if (!ragConnect.errors().isEmpty()) { - LOGGER.severe("Errors:"); + StringBuilder sb = new StringBuilder("Errors:\n"); for (ErrorMessage e : ragConnect.errors()) { - LOGGER.severe(e.toString()); + sb.append(e).append("\n"); } + LOGGER.severe(sb::toString); System.exit(1); } diff --git a/ragconnect.tests/src/test/java/org/jastadd/ragconnect/tests/MqttHandlerTest.java b/ragconnect.tests/src/test/java/org/jastadd/ragconnect/tests/MqttHandlerTest.java index f8388fd6f2f7a9006f21496f83d309ea2dcace11..091990a64a31c01a6f2c59b934cfe15b6fb76ece 100644 --- a/ragconnect.tests/src/test/java/org/jastadd/ragconnect/tests/MqttHandlerTest.java +++ b/ragconnect.tests/src/test/java/org/jastadd/ragconnect/tests/MqttHandlerTest.java @@ -1,8 +1,6 @@ package org.jastadd.ragconnect.tests; import example.ast.MqttHandler; -import org.assertj.core.api.Assertions; -import org.assertj.core.api.Assumptions; import org.junit.jupiter.api.Tag; import org.junit.jupiter.api.Test; @@ -21,7 +19,6 @@ import static org.junit.jupiter.api.Assertions.assertTrue; * * @author rschoene - Initial contribution */ -@Tag("New") @Tag("mqtt") public class MqttHandlerTest { @@ -55,7 +52,6 @@ public class MqttHandlerTest { assertEquals(1, receivedMessages.size()); } - @Test public void testDontSendWelcomeMessage() throws Exception { MqttHandler welcomeMessageSubscriber = new MqttHandler(); @@ -73,24 +69,4 @@ public class MqttHandlerTest { assertThat(receivedMessages).isEmpty(); } - @Test - public void testSecondHost() throws Exception { - // only run this if we have a second mqtt broker running - Assumptions.assumeThat(TestUtils.getSecondMqttHost()).isNotNull(); - - MqttHandler welcomeMessageSubscriber = new MqttHandler(); - List<String> receivedMessages = new ArrayList<>(); - welcomeMessageSubscriber.setHost(TestUtils.getSecondMqttHost()); - assertTrue(welcomeMessageSubscriber.waitUntilReady(2, TimeUnit.SECONDS)); - welcomeMessageSubscriber.newConnection("components", bytes -> receivedMessages.add(new String(bytes))); - assertThat(receivedMessages).isEmpty(); - - MqttHandler handler = new MqttHandler(); - handler.setHost(TestUtils.getSecondMqttHost()); - assertTrue(handler.waitUntilReady(2, TimeUnit.SECONDS)); - TestUtils.waitForMqtt(); - - assertEquals(1, receivedMessages.size()); - } - } diff --git a/ragconnect.tests/src/test/java/org/jastadd/ragconnect/tests/TestUtils.java b/ragconnect.tests/src/test/java/org/jastadd/ragconnect/tests/TestUtils.java index 53d737c27c858c4f1dc27e77a42d8f50dda29dec..2d08ccb376a6abaadf6643b32182c1ed5c10acda 100644 --- a/ragconnect.tests/src/test/java/org/jastadd/ragconnect/tests/TestUtils.java +++ b/ragconnect.tests/src/test/java/org/jastadd/ragconnect/tests/TestUtils.java @@ -29,16 +29,6 @@ public class TestUtils { } } - public static String getSecondMqttHost() { - if (System.getenv("GITLAB_CI") != null) { - // we are in the CI, so use "mqtt_different_port" as host and 55883 as port - return "mqtt_different_port:55883"; - } { - // else no second local mqtt broker - return null; - } - } - public static String mqttUri(String path) { return "mqtt://" + getMqttHost() + "/" + path; }