From 58ee13979de5be272c7dadfc4ffc7bb7b71054c2 Mon Sep 17 00:00:00 2001
From: Rodrigo Queiro <rodrigoq@google.com>
Date: Wed, 31 Jan 2018 17:03:51 +0100
Subject: [PATCH] Use Arrays.hashCode() instead of Object.hashCode()
Explanation:
https://github.com/google/error-prone/blob/master/docs/bugpattern/ArrayHashCode.md
---
.../java/org/ros/internal/message/field/BooleanArrayField.java | 2 +-
.../java/org/ros/internal/message/field/ByteArrayField.java | 2 +-
.../java/org/ros/internal/message/field/DoubleArrayField.java | 2 +-
.../java/org/ros/internal/message/field/FloatArrayField.java | 2 +-
.../java/org/ros/internal/message/field/IntegerArrayField.java | 2 +-
.../java/org/ros/internal/message/field/LongArrayField.java | 2 +-
.../java/org/ros/internal/message/field/ShortArrayField.java | 2 +-
7 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/message_generation/src/main/java/org/ros/internal/message/field/BooleanArrayField.java b/message_generation/src/main/java/org/ros/internal/message/field/BooleanArrayField.java
index 75a9fe1..9ec6bfe 100644
--- a/message_generation/src/main/java/org/ros/internal/message/field/BooleanArrayField.java
+++ b/message_generation/src/main/java/org/ros/internal/message/field/BooleanArrayField.java
@@ -94,7 +94,7 @@ public class BooleanArrayField extends Field {
public int hashCode() {
final int prime = 31;
int result = super.hashCode();
- result = prime * result + ((value == null) ? 0 : value.hashCode());
+ result = prime * result + ((value == null) ? 0 : Arrays.hashCode(value));
return result;
}
diff --git a/message_generation/src/main/java/org/ros/internal/message/field/ByteArrayField.java b/message_generation/src/main/java/org/ros/internal/message/field/ByteArrayField.java
index 02e08bf..e8967ee 100644
--- a/message_generation/src/main/java/org/ros/internal/message/field/ByteArrayField.java
+++ b/message_generation/src/main/java/org/ros/internal/message/field/ByteArrayField.java
@@ -94,7 +94,7 @@ public class ByteArrayField extends Field {
public int hashCode() {
final int prime = 31;
int result = super.hashCode();
- result = prime * result + ((value == null) ? 0 : value.hashCode());
+ result = prime * result + ((value == null) ? 0 : Arrays.hashCode(value));
return result;
}
diff --git a/message_generation/src/main/java/org/ros/internal/message/field/DoubleArrayField.java b/message_generation/src/main/java/org/ros/internal/message/field/DoubleArrayField.java
index a0c3945..04e54b7 100644
--- a/message_generation/src/main/java/org/ros/internal/message/field/DoubleArrayField.java
+++ b/message_generation/src/main/java/org/ros/internal/message/field/DoubleArrayField.java
@@ -94,7 +94,7 @@ public class DoubleArrayField extends Field {
public int hashCode() {
final int prime = 31;
int result = super.hashCode();
- result = prime * result + ((value == null) ? 0 : value.hashCode());
+ result = prime * result + ((value == null) ? 0 : Arrays.hashCode(value));
return result;
}
diff --git a/message_generation/src/main/java/org/ros/internal/message/field/FloatArrayField.java b/message_generation/src/main/java/org/ros/internal/message/field/FloatArrayField.java
index fcbf50c..630a81a 100644
--- a/message_generation/src/main/java/org/ros/internal/message/field/FloatArrayField.java
+++ b/message_generation/src/main/java/org/ros/internal/message/field/FloatArrayField.java
@@ -94,7 +94,7 @@ public class FloatArrayField extends Field {
public int hashCode() {
final int prime = 31;
int result = super.hashCode();
- result = prime * result + ((value == null) ? 0 : value.hashCode());
+ result = prime * result + ((value == null) ? 0 : Arrays.hashCode(value));
return result;
}
diff --git a/message_generation/src/main/java/org/ros/internal/message/field/IntegerArrayField.java b/message_generation/src/main/java/org/ros/internal/message/field/IntegerArrayField.java
index adb0753..8138a4e 100644
--- a/message_generation/src/main/java/org/ros/internal/message/field/IntegerArrayField.java
+++ b/message_generation/src/main/java/org/ros/internal/message/field/IntegerArrayField.java
@@ -94,7 +94,7 @@ public class IntegerArrayField extends Field {
public int hashCode() {
final int prime = 31;
int result = super.hashCode();
- result = prime * result + ((value == null) ? 0 : value.hashCode());
+ result = prime * result + ((value == null) ? 0 : Arrays.hashCode(value));
return result;
}
diff --git a/message_generation/src/main/java/org/ros/internal/message/field/LongArrayField.java b/message_generation/src/main/java/org/ros/internal/message/field/LongArrayField.java
index 8c2a611..a3f2ca3 100644
--- a/message_generation/src/main/java/org/ros/internal/message/field/LongArrayField.java
+++ b/message_generation/src/main/java/org/ros/internal/message/field/LongArrayField.java
@@ -96,7 +96,7 @@ public class LongArrayField extends Field {
public int hashCode() {
final int prime = 31;
int result = super.hashCode();
- result = prime * result + ((value == null) ? 0 : value.hashCode());
+ result = prime * result + ((value == null) ? 0 : Arrays.hashCode(value));
return result;
}
diff --git a/message_generation/src/main/java/org/ros/internal/message/field/ShortArrayField.java b/message_generation/src/main/java/org/ros/internal/message/field/ShortArrayField.java
index e77b72a..bb8209b 100644
--- a/message_generation/src/main/java/org/ros/internal/message/field/ShortArrayField.java
+++ b/message_generation/src/main/java/org/ros/internal/message/field/ShortArrayField.java
@@ -94,7 +94,7 @@ public class ShortArrayField extends Field {
public int hashCode() {
final int prime = 31;
int result = super.hashCode();
- result = prime * result + ((value == null) ? 0 : value.hashCode());
+ result = prime * result + ((value == null) ? 0 : Arrays.hashCode(value));
return result;
}
--
GitLab